Tweak Queued Writes help output

This commit is contained in:
Philip O'Toole
2025-08-13 09:01:52 -04:00
committed by GitHub
parent 03b68b1c44
commit 4b040d29cd
3 changed files with 10 additions and 9 deletions

View File

@@ -7,6 +7,7 @@
- [PR #2211](https://github.com/rqlite/rqlite/pull/2211): Further CDC-FIFO integration.
- [PR #2214](https://github.com/rqlite/rqlite/pull/2214): Pass node ID to CDC Service.
- [PR #2216](https://github.com/rqlite/rqlite/pull/2216): Add support for JSON-based CDC configuration.
- [PR #2217](https://github.com/rqlite/rqlite/pull/2217): Tweak Queued Writes help output.
## v8.43.2 (August 6th 2025)
### Implementation changes and bug fixes

View File

@@ -111,11 +111,11 @@ type Config struct {
RaftReapReadOnlyNodeTimeout time.Duration
// Timeout for initial connection to other nodes
ClusterConnectTimeout time.Duration
// QueuedWrites queue capacity
// Queued Writes queue capacity
WriteQueueCap int
// QueuedWrites queue batch size
// Queued Writes queue batch size
WriteQueueBatchSz int
// QueuedWrites queue timeout
// Queued Writes queue timeout
WriteQueueTimeout time.Duration
// Use a transaction when processing a queued write
WriteQueueTx bool
@@ -184,9 +184,9 @@ func Forge(arguments []string) (*flag.FlagSet, *Config, error) {
fs.DurationVar(&config.RaftReapNodeTimeout, "raft-reap-node-timeout", mustParseDuration("0h"), "Time after which a non-reachable voting node will be reaped. If not set, no reaping takes place")
fs.DurationVar(&config.RaftReapReadOnlyNodeTimeout, "raft-reap-read-only-node-timeout", mustParseDuration("0h"), "Time after which a non-reachable non-voting node will be reaped. If not set, no reaping takes place")
fs.DurationVar(&config.ClusterConnectTimeout, "cluster-connect-timeout", mustParseDuration("30s"), "Timeout for initial connection to other nodes")
fs.IntVar(&config.WriteQueueCap, "write-queue-capacity", 1024, "QueuedWrites queue capacity")
fs.IntVar(&config.WriteQueueBatchSz, "write-queue-batch-size", 128, "QueuedWrites queue batch size")
fs.DurationVar(&config.WriteQueueTimeout, "write-queue-timeout", mustParseDuration("50ms"), "QueuedWrites queue timeout")
fs.IntVar(&config.WriteQueueCap, "write-queue-capacity", 1024, "Queued Writes queue capacity")
fs.IntVar(&config.WriteQueueBatchSz, "write-queue-batch-size", 128, "Queued Writes queue batch size")
fs.DurationVar(&config.WriteQueueTimeout, "write-queue-timeout", mustParseDuration("50ms"), "Queued Writes queue timeout")
fs.BoolVar(&config.WriteQueueTx, "write-queue-tx", false, "Use a transaction when processing a queued write")
fs.StringVar(&config.CPUProfile, "cpu-profile", "", "Path to file for CPU profiling information")
fs.StringVar(&config.MemProfile, "mem-profile", "", "Path to file for memory profiling information")

View File

@@ -495,7 +495,7 @@ default = "30s"
name = "WriteQueueCap"
cli = "write-queue-capacity"
type = "int"
short_help = "QueuedWrites queue capacity"
short_help = "Queued Writes queue capacity"
long_help = """
The larger this value the more Queued Write requests can be queued up internally by the node. This queue is asynchronously drained, as requests are transmitted through the Raft log. Any time the queue is full Queued Writes requests are blocked.
"""
@@ -505,7 +505,7 @@ default = 1024
name = "WriteQueueBatchSz"
cli = "write-queue-batch-size"
type = "int"
short_help = "QueuedWrites queue batch size"
short_help = "Queued Writes queue batch size"
long_help = """
The larger the batch size the more Queued Write statements will be batched from the internal queue and stored in a single Raft log entry. However, larger batches will consume more memory, and may increase latency.
"""
@@ -515,7 +515,7 @@ default = 128
name = "WriteQueueTimeout"
cli = "write-queue-timeout"
type = "time.Duration"
short_help = "QueuedWrites queue timeout"
short_help = "Queued Writes queue timeout"
long_help = """
"""
default = "50ms"