fbdev: pxafb: Fix multiple clamped values in pxafb_adjust_timing

The variables were never clamped because the return value of clamp_val()
was not used. Fix this by assigning the clamped values, and use clamp()
instead of clamp_val().

Cc: stable@vger.kernel.org
Fixes: 3f16ff608a ("[ARM] pxafb: cleanup of the timing checking code")
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Helge Deller <deller@gmx.de>
This commit is contained in:
Thorsten Blum
2025-12-02 19:15:32 +01:00
committed by Helge Deller
parent 35fa2b4bf9
commit 0155e868cb

View File

@@ -419,12 +419,12 @@ static int pxafb_adjust_timing(struct pxafb_info *fbi,
var->yres = max_t(int, var->yres, MIN_YRES);
if (!(fbi->lccr0 & LCCR0_LCDT)) {
clamp_val(var->hsync_len, 1, 64);
clamp_val(var->vsync_len, 1, 64);
clamp_val(var->left_margin, 1, 255);
clamp_val(var->right_margin, 1, 255);
clamp_val(var->upper_margin, 1, 255);
clamp_val(var->lower_margin, 1, 255);
var->hsync_len = clamp(var->hsync_len, 1, 64);
var->vsync_len = clamp(var->vsync_len, 1, 64);
var->left_margin = clamp(var->left_margin, 1, 255);
var->right_margin = clamp(var->right_margin, 1, 255);
var->upper_margin = clamp(var->upper_margin, 1, 255);
var->lower_margin = clamp(var->lower_margin, 1, 255);
}
/* make sure each line is aligned on word boundary */