Ything-RepoMirrors/libgit2
2
0
Fork 0
mirror of https://github.com/libgit2/libgit2.git synced 2026-01-25 02:56:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

tag: Refuse to use HEAD as a tagname

Browse Source 
Sync with vanilla Git, cf. https://github.com/git/git/commit/bbd445d5efd415

Signed-off-by: Sven Strickroth <email@cs-ware.de>
This commit is contained in:
Sven Strickroth
2025-04-07 21:18:20 +02:00
parent 21a351b0ed
commit 3dc766a875
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/libgit2/tag.c
View File

@@ -263,8 +263,10 @@ static bool tag_name_is_valid(const char *tag_name)
/*
* Discourage tag name starting with dash,
* https://github.com/git/git/commit/4f0accd638b8d2
* and refuse to use HEAD as a tagname,
* https://github.com/git/git/commit/bbd445d5efd415
*/
return tag_name[0] != '-';
return tag_name[0] != '-' && git__strcmp(tag_name, "HEAD");
}
static int git_tag_create__internal(

2
tests/libgit2/refs/tags/name.c
View File

@@ -11,7 +11,9 @@ void test_refs_tags_name__is_name_valid(void)
{
cl_assert_equal_i(true, name_is_valid("sometag"));
cl_assert_equal_i(true, name_is_valid("test/sometag"));
cl_assert_equal_i(true, name_is_valid("test/HEAD"));
cl_assert_equal_i(false, name_is_valid(""));
cl_assert_equal_i(false, name_is_valid("-dash"));
cl_assert_equal_i(false, name_is_valid("HEAD"));
}