Ything-RepoMirrors/libgit2
2
0
Fork 0
mirror of https://github.com/libgit2/libgit2.git synced 2026-01-25 02:56:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5387 from pks-t/pks/transport-http-custom-headers

Browse Source 
transports: http: fix custom headers not being applied
This commit is contained in:
Patrick Steinhardt
2020-02-07 11:36:36 +01:00
committed by GitHub
parent 65ac33aeb1 46228d86f8
commit 03ac24b119
2 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/transports/http.c
View File

@@ -346,6 +346,7 @@ static int generate_request(
request->credentials = transport->server.cred;
request->proxy = use_proxy ? &transport->proxy.url : NULL;
request->proxy_credentials = transport->proxy.cred;
request->custom_headers = &transport->owner->custom_headers;
if (stream->service->method == GIT_HTTP_METHOD_POST) {
request->chunked = stream->service->chunked;

15
tests/online/clone.c
View File

@@ -392,6 +392,21 @@ void test_online_clone__credentials(void)
cl_fixture_cleanup("./foo");
}
void test_online_clone__credentials_via_custom_headers(void)
{
const char *creds = "libgit3:libgit3";
git_buf auth = GIT_BUF_INIT;
cl_git_pass(git_buf_puts(&auth, "Authorization: Basic "));
cl_git_pass(git_buf_encode_base64(&auth, creds, strlen(creds)));
g_options.fetch_opts.custom_headers.count = 1;
g_options.fetch_opts.custom_headers.strings = &auth.ptr;
cl_git_pass(git_clone(&g_repo, "https://bitbucket.org/libgit2/testgitrepository.git", "./foo", &g_options));
git_buf_dispose(&auth);
}
void test_online_clone__bitbucket_style(void)
{
git_credential_userpass_payload user_pass = {