Ything-RepoMirrors/static-web-server
2
0
Fork 0
mirror of https://github.com/static-web-server/static-web-server.git synced 2026-01-25 05:06:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: prevent single wildcards from matching path separators for URL Rewrites (#506)

Browse Source 
* refactor: prevent single wildcards from matching path separators for URL Rewrites

* Fix log output in documentation

BREAKING CHANGE: Up to version 2.33.1 the wildcard `*` was matching the path separator. For example, `/{*}/{*}/` matched `/assets/images/logo/`. In later versions, the default has changed such that `*` does not match the path separator. In contrast, double wildcard (`**`) can match also a path separator.
This commit is contained in:
Matthias Schoettle
2024-12-02 00:54:10 -05:00
committed by GitHub
parent 12387a88bb
commit 2737f4c4ca
4 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/content/features/url-redirects.md
View File

@@ -35,7 +35,7 @@ The glob pattern functionality is powered by the [globset](https://docs.rs/globs
For more details about the Glob pattern syntax check out https://docs.rs/globset/latest/globset/#syntax
!!! warning "Matching of path separator in `*`"
Up to version 2.33.1 the wildcard `*` was matching the path separator.
Up to version `2.33.1` the wildcard `*` was matching the path separator.
For example, `/{*}/{*}/` matched `/assets/images/logo/`.
In later versions, the default has changed such that `*` does not match the path separator.

8
docs/content/features/url-rewrites.md
View File

@@ -26,6 +26,12 @@ The glob pattern functionality is powered by the [globset](https://docs.rs/globs
!!! tip "Glob pattern syntax"
For more details about the Glob pattern syntax check out https://docs.rs/globset/latest/globset/#syntax
!!! warning "Matching of path separator in `*`"
Up to version `2.33.1` the wildcard `*` was matching the path separator.
For example, `/{*}/{*}/` matched `/assets/images/logo/`.
In later versions, the default has changed such that `*` does not match the path separator.
### Destination
The value should be a relative or absolute URL. A relative URL could look like `/some/directory/file.html`. An absolute URL can be `https://external.example.com/` for example.
@@ -119,7 +125,7 @@ Then the server logs should look something like this:
```log
2023-07-08T20:31:36.606035Z INFO static_web_server::handler: incoming request: method=HEAD uri=/abcdef.png
2023-07-08T20:31:36.608439Z DEBUG static_web_server::handler: url rewrites glob patterns: ["$0", "$1", "$2"]
2023-07-08T20:31:36.608491Z DEBUG static_web_server::handler: url rewrites regex equivalent: (?-u:\b)(?:/?|.*/)(.*)\.(gif|png)$
2023-07-08T20:31:36.608491Z DEBUG static_web_server::handler: url rewrites regex equivalent: (?-u)^(?:/?|.*/)(?:[^/]*)\.(?:gif|png)$
2023-07-08T20:31:36.608525Z DEBUG static_web_server::handler: url rewrites glob pattern captures: ["abcdef.png", "abcdef", "png"]
2023-07-08T20:31:36.608561Z DEBUG static_web_server::handler: url rewrites glob pattern destination: "/assets/$1.$2"
2023-07-08T20:31:36.609655Z DEBUG static_web_server::handler: url rewrites glob patterns destination replaced: "/assets/abcdef.png"