Ything-RepoMirrors/rqlite
1
0
Fork 0
mirror of https://github.com/rqlite/rqlite.git synced 2026-01-25 04:16:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove read-only check in Query handler

Browse Source 
The SQLite connection itself will enforce the read-only nature of the Query path.
This commit is contained in:
Philip O'Toole
2026-01-06 14:57:04 -05:00
committed by GitHub
parent fdd7ac15bf
commit 6acbe3c730
1 changed files with 1 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
db/db.go
View File

@@ -1156,28 +1156,7 @@ func (db *DB) queryWithConn(ctx context.Context, req *command.Request, xTime boo
continue
}
var rows *command.QueryRows
var err error
readOnly, err := db.StmtReadOnlyWithConn(sql, conn)
if err != nil {
stats.Add(numQueryErrors, 1)
rows = &command.QueryRows{
Error: err.Error(),
}
allRows = append(allRows, rows)
continue
}
if !readOnly {
stats.Add(numQueryErrors, 1)
rows = &command.QueryRows{
Error: "attempt to change database via query operation",
}
allRows = append(allRows, rows)
continue
}
rows, err = db.queryStmtWithConn(ctx, stmt, xTime, queryer)
rows, err := db.queryStmtWithConn(ctx, stmt, xTime, queryer)
if err != nil {
stats.Add(numQueryErrors, 1)
rows = &command.QueryRows{