From c28ebdf25649aeffdcb40bbb57ebc0ec42d07cc9 Mon Sep 17 00:00:00 2001 From: Edward Thomson Date: Mon, 27 Feb 2023 20:38:02 +0000 Subject: [PATCH] Revert "tests: validate host and port for ssh tests when non-standard" This reverts commit 43e84e246cc716ac51a276945b5b112b21d802d1. --- tests/libgit2/online/clone.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/tests/libgit2/online/clone.c b/tests/libgit2/online/clone.c index bb704c066..1a4cdb520 100644 --- a/tests/libgit2/online/clone.c +++ b/tests/libgit2/online/clone.c @@ -787,19 +787,10 @@ static int ssh_certificate_check(git_cert *cert, int valid, const char *host, vo { git_cert_hostkey *key; git_oid expected = GIT_OID_SHA1_ZERO, actual = GIT_OID_SHA1_ZERO; - git_str expected_host = GIT_STR_INIT; - git_net_url parsed_url = GIT_NET_URL_INIT; GIT_UNUSED(valid); GIT_UNUSED(payload); - cl_git_pass(git_net_url_parse_standard_or_scp(&parsed_url, _remote_url)); - cl_git_pass(git_str_printf(&expected_host, "%s%s%s", - parsed_url.host, - git_net_url_is_default_port(&parsed_url) ? "" : ":", - git_net_url_is_default_port(&parsed_url) ? "" : parsed_url.port)); - cl_assert_equal_s(expected_host.ptr, host); - cl_assert(_remote_ssh_fingerprint); cl_git_pass(git_oid__fromstrp(&expected, _remote_ssh_fingerprint, GIT_OID_SHA1)); @@ -821,8 +812,7 @@ static int ssh_certificate_check(git_cert *cert, int valid, const char *host, vo cl_assert(!memcmp(&expected, &actual, 20)); - git_net_url_dispose(&parsed_url); - git_str_dispose(&expected_host); + cl_assert_equal_s("localhost", host); return GIT_EUSER; }