Ything-RepoMirrors/libgit2
2
0
Fork 0
mirror of https://github.com/libgit2/libgit2.git synced 2026-01-25 02:56:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

process: resolve paths for win32

Browse Source 
When using `git_process_new` on win32, resolve the path to the
application in the same way that we do on POSIX.

Search `PATH` for command to execute (unless the given executable is
fully qualified). In addition, better match Windows executable lookup
behavior itself (allowing the command to be `foo`, and looking for a
matching `foo.exe` or `foo.cmd`.)
This commit is contained in:
Edward Thomson
2025-12-01 00:55:36 -08:00
parent 98ba974617
commit 2ad709e77c
3 changed files with 138 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
tests/util/process/start.c
View File

@@ -78,6 +78,52 @@ void test_process_start__not_found(void)
git_process_free(process);
}
void test_process_start__finds_in_path(void)
{
#ifdef GIT_WIN32
const char *args_array[] = { "cmd", "/c", "exit", "0" };
#else
const char *args_array[] = { "true" };
#endif
git_process *process;
git_process_options opts = GIT_PROCESS_OPTIONS_INIT;
git_process_result result = GIT_PROCESS_RESULT_INIT;
cl_git_pass(git_process_new(&process, args_array, ARRAY_SIZE(args_array), NULL, 0, &opts));
cl_git_pass(git_process_start(process));
cl_git_pass(git_process_wait(&result, process));
cl_assert_equal_i(GIT_PROCESS_STATUS_NORMAL, result.status);
cl_assert_equal_i(0, result.exitcode);
cl_assert_equal_i(0, result.signal);
git_process_free(process);
}
void test_process_start__adds_suffix(void)
{
#ifdef GIT_WIN32
const char *args_array[] = { "C:\\Windows\\System32\\cmd", "/c", "exit", "0" };
git_process *process;
git_process_options opts = GIT_PROCESS_OPTIONS_INIT;
git_process_result result = GIT_PROCESS_RESULT_INIT;
cl_git_pass(git_process_new(&process, args_array, ARRAY_SIZE(args_array), NULL, 0, &opts));
cl_git_pass(git_process_start(process));
cl_git_pass(git_process_wait(&result, process));
cl_assert_equal_i(GIT_PROCESS_STATUS_NORMAL, result.status);
cl_assert_equal_i(0, result.exitcode);
cl_assert_equal_i(0, result.signal);
git_process_free(process);
#else
cl_skip();
#endif
}
static void write_all(git_process *process, char *buf)
{
size_t buf_len = strlen(buf);