From 7f06b8e3346626616dd9a62a373e56d1f67c5bc3 Mon Sep 17 00:00:00 2001 From: Jingyu Zhou Date: Mon, 19 Jan 2026 13:59:48 -0800 Subject: [PATCH] Fix IDE build compiling errors --- fdbserver/CommitProxyServer.actor.cpp | 1 - fdbserver/RemoteIKeyValueStore.actor.cpp | 2 ++ fdbserver/worker.actor.cpp | 1 - fdbserver/workloads/BackupCorrectness.actor.cpp | 2 -- fdbserver/workloads/BackupCorrectnessPartitioned.actor.cpp | 2 -- fdbserver/workloads/BackupS3BlobCorrectness.actor.cpp | 6 ++++-- fdbserver/workloads/ReadHotDetection.actor.cpp | 1 + fdbserver/workloads/RestoreValidation.actor.cpp | 4 ---- 8 files changed, 7 insertions(+), 12 deletions(-) diff --git a/fdbserver/CommitProxyServer.actor.cpp b/fdbserver/CommitProxyServer.actor.cpp index 7aa532db77..b581a60663 100644 --- a/fdbserver/CommitProxyServer.actor.cpp +++ b/fdbserver/CommitProxyServer.actor.cpp @@ -1422,7 +1422,6 @@ ACTOR Future assignMutationsToStorageServers(CommitBatchContext* self) { ASSERT_EQ(encryptedMutations->size(), pMutations->size()); } - state int64_t encryptDomain = FDB_DEFAULT_ENCRYPT_DOMAIN_ID; self->toCommit.addTransactionInfo(trs[self->transactionNum].spanContext); for (; mutationNum < pMutations->size(); mutationNum++) { diff --git a/fdbserver/RemoteIKeyValueStore.actor.cpp b/fdbserver/RemoteIKeyValueStore.actor.cpp index b9a3cbd596..3f9e90e334 100644 --- a/fdbserver/RemoteIKeyValueStore.actor.cpp +++ b/fdbserver/RemoteIKeyValueStore.actor.cpp @@ -140,6 +140,7 @@ ACTOR Future runIKVS(OpenKVStoreRequest openReq, IKVSInterface ikvsInterfa forwardPromise(onClosedReq.reply, kvStore->onClosed()); } when(IKVSDisposeRequest disposeReq = waitNext(ikvsInterface.dispose.getFuture())) { + (void)disposeReq; // suppress unused variable warning TraceEvent(SevDebug, "RemoteIKVSDisposeReceivedRequest").detail("UID", kvsId); kvStore->dispose(); guard.invalidate(); @@ -147,6 +148,7 @@ ACTOR Future runIKVS(OpenKVStoreRequest openReq, IKVSInterface ikvsInterfa return Void(); } when(IKVSCloseRequest closeReq = waitNext(ikvsInterface.close.getFuture())) { + (void)closeReq; // suppress unused variable warning TraceEvent(SevDebug, "RemoteIKVSCloseReceivedRequest").detail("UID", kvsId); kvStore->close(); guard.invalidate(); diff --git a/fdbserver/worker.actor.cpp b/fdbserver/worker.actor.cpp index f2be38f0aa..65f82e8e0a 100644 --- a/fdbserver/worker.actor.cpp +++ b/fdbserver/worker.actor.cpp @@ -4170,7 +4170,6 @@ const Role Role::TESTER("Tester", "TS"); const Role Role::LOG_ROUTER("LogRouter", "LR"); const Role Role::DATA_DISTRIBUTOR("DataDistributor", "DD"); const Role Role::RATEKEEPER("Ratekeeper", "RK"); -const Role Role::STORAGE_CACHE("StorageCache", "SC"); const Role Role::COORDINATOR("Coordinator", "CD"); const Role Role::BACKUP("Backup", "BK"); const Role Role::ENCRYPT_KEY_PROXY("EncryptKeyProxy", "EP"); diff --git a/fdbserver/workloads/BackupCorrectness.actor.cpp b/fdbserver/workloads/BackupCorrectness.actor.cpp index 4b0678a63b..fa3147d425 100644 --- a/fdbserver/workloads/BackupCorrectness.actor.cpp +++ b/fdbserver/workloads/BackupCorrectness.actor.cpp @@ -187,8 +187,6 @@ struct BackupAndRestoreCorrectnessWorkload : TestWorkload { } ACTOR Future _setup(Database cx, BackupAndRestoreCorrectnessWorkload* self) { - state bool adjusted = false; - if (BUGGIFY) { for (auto r : getSystemBackupRanges()) { self->backupRanges.push_back_deep(self->backupRanges.arena(), r); diff --git a/fdbserver/workloads/BackupCorrectnessPartitioned.actor.cpp b/fdbserver/workloads/BackupCorrectnessPartitioned.actor.cpp index 9e9aaf00c0..2affd5b26b 100644 --- a/fdbserver/workloads/BackupCorrectnessPartitioned.actor.cpp +++ b/fdbserver/workloads/BackupCorrectnessPartitioned.actor.cpp @@ -185,8 +185,6 @@ struct BackupAndRestorePartitionedCorrectnessWorkload : TestWorkload { } ACTOR Future _setup(Database cx, BackupAndRestorePartitionedCorrectnessWorkload* self) { - state bool adjusted = false; - if (BUGGIFY) { for (auto r : getSystemBackupRanges()) { self->backupRanges.push_back_deep(self->backupRanges.arena(), r); diff --git a/fdbserver/workloads/BackupS3BlobCorrectness.actor.cpp b/fdbserver/workloads/BackupS3BlobCorrectness.actor.cpp index 8bed949bb7..1c15fe7b00 100644 --- a/fdbserver/workloads/BackupS3BlobCorrectness.actor.cpp +++ b/fdbserver/workloads/BackupS3BlobCorrectness.actor.cpp @@ -643,7 +643,7 @@ struct BackupS3BlobCorrectnessWorkload : TestWorkload { Standalone restoreTag(self->backupTag.toString() + "_restore"); // Pass lockDB=False since we already locked, unlockDB=True to release when done, // and our lockUID so restore uses the same lock for checkDatabaseLock calls - Version _ = wait(backupAgent.restore(cx, + Version v = wait(backupAgent.restore(cx, cx, restoreTag, KeyRef(lastBackupContainer->getURL()), @@ -662,7 +662,9 @@ struct BackupS3BlobCorrectnessWorkload : TestWorkload { lastBackupContainer->getEncryptionKeyFileName(), lockUID)); - TraceEvent("BS3BCW_RestoreComplete").detail("BackupTag", printable(self->backupTag)); + TraceEvent("BS3BCW_RestoreComplete") + .detail("BackupTag", printable(self->backupTag)) + .detail("RestoreVersion", v); } } diff --git a/fdbserver/workloads/ReadHotDetection.actor.cpp b/fdbserver/workloads/ReadHotDetection.actor.cpp index a799be92be..0e85dafe61 100644 --- a/fdbserver/workloads/ReadHotDetection.actor.cpp +++ b/fdbserver/workloads/ReadHotDetection.actor.cpp @@ -98,6 +98,7 @@ struct ReadHotDetectionWorkload : TestWorkload { state Transaction tr(cx); try { StorageMetrics sm = wait(cx->getStorageMetrics(self->wholeRange, 100)); + (void)sm; // suppress unused variable warning // TraceEvent("RHDCheckPhaseLog") // .detail("KeyRangeSize", sm.bytes) // .detail("KeyRangeReadBandwidth", sm.bytesReadPerKSecond); diff --git a/fdbserver/workloads/RestoreValidation.actor.cpp b/fdbserver/workloads/RestoreValidation.actor.cpp index 289c4edae5..1fa0260c0c 100644 --- a/fdbserver/workloads/RestoreValidation.actor.cpp +++ b/fdbserver/workloads/RestoreValidation.actor.cpp @@ -95,7 +95,6 @@ struct RestoreValidationWorkload : TestWorkload { // Wait for restore completion marker // BackupAndRestoreValidation sets this key when restore is fully complete state Key completionMarker = "\xff\x02/restoreValidationComplete"_sr; - state bool restoreComplete = false; state int checkAttempts = 0; TraceEvent("RestoreValidationWaitingForRestoreCompletion") @@ -109,7 +108,6 @@ struct RestoreValidationWorkload : TestWorkload { Optional markerValue = wait(tr.get(completionMarker)); if (markerValue.present()) { - restoreComplete = true; TraceEvent("RestoreValidationRestoreComplete").detail("CheckAttempts", checkAttempts); break; } @@ -191,7 +189,6 @@ struct RestoreValidationWorkload : TestWorkload { // Monitor audit progress state double startTime = now(); state double lastReportTime = startTime; - state bool completed = false; state AuditPhase finalPhase = AuditPhase::Invalid; state std::string errorMessage; @@ -264,7 +261,6 @@ struct RestoreValidationWorkload : TestWorkload { } if (allComplete || anyError) { - completed = true; break; } }